[patch] reading from stdin in KWrite

[David Faure]

On Monday 02 June 2003 11:54, Daniel Stone wrote:
> On Mon, Jun 02, 2003 at 11:48:30AM +0200, Waldo Bastian wrote:
> > On Monday 02 June 2003 10:37, Daniel Stone wrote:
> > > On Mon, Jun 02, 2003 at 12:42:44AM +0200, Scott Wheeler wrote:
> > > > The biggest part of this patch is a s/katePart/m_katePart/ since I needed
> > > > to add a method called katePart() and since the m_ is used on other
> > > > member variables this seemed like the way to go.
> > >
> > > Given that studlyCappedVariables seems to be standard in most KDE apps,
> > > why_did_you_descend_into_underscore_hell? IMO, mKatePart is very easy to
> > > read, whereas m_katePart just looks ugly. Surely we don't need to mix
> > > and match two naming styles? It feels to me like mixing and matching
> > > spaces and tabs as a method of indentation.
> > 
> > You seem to be poorly informed. The m_ prefix is widely used throughout KDE to 
> > indicate that the variable is a class member. 
> 
> Hmm, I've not seen it much.

You should read more KDE code then.

/mnt/devel/kde/kdecvs/kdelibs/kdecore>grep ' m_' *h | wc -l
    185

/mnt/devel/kde/kdecvs/kdebase/konqueror>grep ' m_' *h | wc -l
    188

/mnt/devel/kde/kdecvs/koffice/kword>grep ' m_' *h | wc -l
    691

-- 
David Faure -- faure at kde.org, dfaure at klaralvdalens-datakonsult.se
Qt/KDE/KOffice developer
Klarälvdalens Datakonsult AB, Platform-independent software solutions