[PATCH]: KURLDrag::decode() and the use of explicit

[Waldo Bastian]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Saturday 19 July 2003 10:14, André Wöbbeking wrote:
> Hi,
>
> the attached patch fixes KURLDrag::decode(). Right now an encoded URL is
> encoded once more and not decoded (i.e. %B0 ('°') becomes %C3%82%C2%B0
> if your local encoding is UTF-8 or if you use any other protocol than
> file://).
>
> This bug could be avoided if the contructors of KURL would be explicit.
> All the implicit casts in KDE and Qt make it difficult to read the code
> (you don't see what happens) and make it easy to oversee bugs like in
> KURLDrag::decode(). If you don't know what I mean then tell me what the
> following code does:

I think adding explicit would break source compatibility. Other than I think 
it's a good idea to add it (locally) to see what breaks and convert all code 
in CVS to use explicit casts.

> P.S.: can I apply the patch?

Yes, please.

Cheers,
Waldo
- -- 
bastian at kde.org -=|[ SuSE, The Linux Desktop Experts ]|=- bastian at suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE/G6RyN4pvrENfboIRAiInAJ9v2/4fDIyDuu7XNGr6FS9ftOyRngCeKDdk
da1/pdjHbR2q3H1/+uWfE1E=
=T67Q
-----END PGP SIGNATURE-----