$(shell) in Makefiles, kdoctools/ and kwin4/

[Adriaan de Groot]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 14 July 2003 20:33, Dirk Mueller wrote:
> Hmm, the kwin4 case is unecessary, removed. The kdelibs one is more
> difficult. I would prefer if meinproc would have a commandline option to
> specify the path and the build system should set that one instead of
> KDELIBS_UNINSTALLED environment variable.

Like this? Not tested very extensively, but it seems to do the trick. I can 
imagine that when meinproc was meant to be pretty sleek, this was not an 
option - to use kcmdlineargs and the like. As it stands, I now need to do 
some build tricks to get meinproc to run during a totally clean build, 
because of its dependence on libkdeui, which isn't in its rpath.

The only thing I might worry about is that SRCDIR is a global QString variable 
- - what was the story about static QStrings being evil?


- -- 
pub  1024D/FEA2A3FE 2002-06-18 Adriaan de Groot <groot at kde.org>
     Key fingerprint = 934E 31AA 80A7 723F 54F9  50ED 76AC EE01 FEA2 A3FE
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (FreeBSD)

iD8DBQE/EwRwdqzuAf6io/4RAkvzAJoCEaYDd+U+QqIkiX0a0JLadxjfPwCgogVu
yEOrr+si732F6HcocVPtDYw=
=TUQ4
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: meinproc.patch
Type: text/x-diff
Size: 4785 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20030714/93ad4ac7/attachment.patch>