KDialogBase patch - make the first widget initially focused

Lubos Lunak l.lunak at suse.cz
Thu Jan 30 11:30:48 GMT 2003

On Wednesday 29 of January 2003 13:59, Waldo Bastian wrote:
> On Wednesday 29 January 2003 12:58, Lubos Lunak wrote:
> >  But forcing it by default on the buttons is wrong IMHO. If I write a
> > dialog based on QDialog, the first widget will have focus, if this dialog
> > is changed to use KDialogBase, suddenly it will be the first button
> > having the focus.
> >
> >  Another try: The KDialogBase patch is almost the same, and there's
> > additional patch for KActiveLabel, as that one IMHO shouldn't actually
> > get focus, as it's a label after all, even though based on QTextBrowser.
> >
> >  Is it ok to commit it?
> I don't think so. Now the ActiveLabel can't get focus at all anymore, no?
> The purpose of KActiveLabel is to be able to select text from it. For that
> you need focus.
> I agree that it shouldn't get focus by default though.

 Yet another try. The KDialogBase patch is the same, no KActiveLabel patch, 
and this time it's KMessageBox who sets the focus on the default button 
instead of doing it in KDialogBase.

 Ok now?

Lubos Lunak
KDE developer
SuSE CR, s.r.o.  e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdialogbase.cpp.patch
Type: text/x-diff
Size: 1192 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20030130/94b3e0de/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kmessagebox.cpp.patch
Type: text/x-diff
Size: 1117 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20030130/94b3e0de/attachment-0001.patch>

More information about the kde-core-devel mailing list