in-place-editing patch for konqueror bookmarks

Aaron J. Seigo aseigo at
Fri Jan 17 10:39:47 GMT 2003

Hash: SHA1

On Friday 17 January 2003 02:57, David Faure wrote:
> On Friday 17 January 2003 09:29, Aaron J. Seigo wrote:
> > On Thursday 16 January 2003 03:04, Oelewapperke wrote:
> > > and middle button ?
> >
> >  i don't think that something that's generic enough behaviour to go into
> > KPopupMenu..
> Why? How does it hurt having a signal from KPopupMenu ?
> This would make things much simpler...

for the number of places it would get used (i could only think of the 
bookmarks when i wrote it, you add the possibility of konsole) it seems like 
added overhead that would hardly get used at all... for those rare corner 
cases, one could write a subclass to do this...  perhaps reading all those 
msgs on the new kde-optimization list are making me a bit paranoid about 
performance =)

thinking about it a bit more though, there woudl be a few odd things to care 
of when implementing this ... you'd basically have to reimplement 
QPopupMenu::mouseReleaseEvent to catch all the corner cases and to keep Qt 
from from emitting activated() as well as the MMB signal... it would be 
easier and safer to extend QPopupMenu::actSig to take a mouse button 
specifier (default to Left, so that key events that call actSig work as 
expected) and emit the appropriate signal... 

> > MMB == LMB should be valid for menus, the bookmarks toolbar
> > being a possible exception.
> What's wrong with "MMB opens the link in a new window" in the bookmarks
> _menu_ too? Wouldn't this be very convenient?

yes, when i wrote "bookmarks toolbar" i meant the bookmarks in general ... my 
bad for not being clear ....

- -- 
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

"Everything should be made as simple as possible, but not simpler"
    - Albert Einstein
Version: GnuPG v1.0.7 (GNU/Linux)


More information about the kde-core-devel mailing list