in-place-editing patch for konqueror bookmarks

Oelewapperke oelewapperke at ulyssis.org
Thu Jan 16 22:02:43 GMT 2003


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 16 January 2003 18:07, David Faure wrote:
> Please reconsider this. You rewrote a complete bookmarkbar implementation
> just to change the menus! There is much duplicated code in your patch,
> which I'm strongly against. This will become a maintainance hell.

This is not true, check the code, I changed both the buttons and the menus 
(and as far as I can see I need to do that)

> All you need is to pass KBookmarkMenu your own popupmenu class,
> and this will work both for the bookmarkbar and for the toplevel bookmarks
> menu. I can do the KActionMenu part of the work if you agree to rework the
> rest around it.
> Thanks.

it will not provide the same options on the buttons if I do it like this.

Oelewapperke
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+JywKJFU6C5Uo8MgRAoPLAKDk97GBdgwbUzgHxdvPF5iyNSISXACdGfgA
IS7j4bQODr/tzJS6ag5egMU=
=9tEa
-----END PGP SIGNATURE-----





More information about the kde-core-devel mailing list