generic classes for safe %macro substitution

Oswald Buddenhagen ossi at kde.org
Wed Jan 1 18:41:50 GMT 2003


On Wed, Jan 01, 2003 at 07:29:42PM +0100, Simon Hausmann wrote:
> One thought: I find it confusing to see KMacroExpanderBase
> inheriting from KMacroExpander (just naming wise) . Why not just
> merge the two classes?
> 
kmacro_map_expanderbase. ;)

> > the derived classes got messier than expected, to be honest.  do you
> > think it would make sense to remove the non-static versions of the
> > functions together with the set*() methods?
> 
> I for one would remove the static methods instead :)
> 
yeah ... i added them for convenience upon request. dunno if it's worth
it.

> > some docu needs to be added before i can add it to kdelibs/kdecore,
> > obviuosly.
> 
> Which applications would make use of these classes
>
an incredible amount, so to say. every application that allows the user
to configure the invocation of external commands with variable
parameters. kdeprint was the trigger to actually do it. but i've seen a
commit to kmail from marc a few minutes ago. look at the components
configuration, external mailer. etc. etc.

> (besides kdm) ?
> 
kdm was my least worry in this case. :)

greetings

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Chaos, panic, and disorder - my work here is done.




More information about the kde-core-devel mailing list