[PATCH] xmlgui: Prevent separators from appearing at the top of menus

Simon Hausmann hausmann at kde.org
Sun Feb 23 09:30:09 GMT 2003

On Sat, Feb 22, 2003 at 06:18:25PM +0100, Stephan Kulow wrote:
> On Samstag, 22. Februar 2003 14:40, Dave Corrie wrote:
> > Hi,
> >
> > I've attached a patch that prevents separators from appearing at the
> > very top of menus. Is it ok to commit?
> >
> > The need for this patch can be seen in katomic (cvs) which has a
> > "Settings" menu containing two standard actions. During the xmlgui
> > merging process, the two corresponding actions and the preceding
> > separator are picked out from the global UI description file.
> >
> > I chose to fix this not at the point of merging, but at the time the GUI
> > is built because if more than one merge happens, later merges might
> > place menu entries at the top of a menu, meaning that a previously
> > removed separator was valid after all. The GUI building code already
> > contains code to prevent two separators from appearing next to each
> > other, so this patch would seem to fit well at this position.
> I'd like to have that patch go into 3_1_BRANCH too. Simon?

Fine with me.


More information about the kde-core-devel mailing list