[PATCH] [pls apply!] Bug #54281 (crash): Konsole crashes on output of certain characters

Karl Vogel karl.vogel at seagha.com
Wed Feb 19 11:28:56 GMT 2003


On 19 Feb 2003, you wrote in kde.kde-core-devel:

> On Sunday 16 February 2003 23:03, Stephan Binner wrote:
>> On Saturday 15 February 2003 13:44, Karl Vogel wrote:
>> > Following patches fix a problem in kdecore which was the reason of the
>> > konsole crashes.
>>
>> Why does kprocess.patch return false? I would say true and drop
>> konsole.patch.
> 
> If it returns true it should also emit wroteStdin()
> 
> I think the following patch fixes it while preserving all the semantics.
> 
> Cheers,
> Waldo

Isn't it wise to also check for a NULL pointer?! I know this is an illegal 
combination (ie. buflen>0 and buffer=NULL), but shouldn't core functions 
guard against improper use, instead of dumping core?!




More information about the kde-core-devel mailing list