cleanup was Re: [PATCH] kopenwith.cpp bugfix and enhancement

[Willy De la Court]

On Wednesday 12 February 2003 14:23, David Faure wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Wednesday 12 February 2003 13:16, Willy De la Court wrote:
> > On Wednesday 12 February 2003 00:59, you wrote:
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA1
> > >
> > > BTW I always find a bit strange checkboxes that are checked _and_
> > > disabled. One always wonder: what is this going to do, that I can't
> > > change? What about not checking that checkbox by default, at least
> > > until enabling it?
> >
> > yes i know i'm going to uncheck it so default is unchecked like it was
> > before i find that new functionality in UI is best left disabled untel
> > the users demand it be made default
>
> Yes.

patch is almost ready
>
> > but there is something else what if the user select a service that
> > already exists and has the "Run in terminal" and No close on exit" also
> > checked i see the code to reenable the "Run in terminal" but the no close
> > on exit wil not be reenabled so thats something i need to fix too.
>
> Yes. But then you have to look for --noclose in the TerminalOptions...

yes not so difficult using m_pService->TerminalOptions() and QString->contains

i'm testing it now

>
> > i'm still thinking about adding a checkbox in the keditfiletype because a
> > normal user does not know about the --noclose so we need to provide a
> > checkbox for it.
>
> ?? Doesn't keditfiletype use KOpenWithDlg for this?

No it does not but it edits the .desktop file which contains the --noclose 
stuff in the TerminalOptions so need to parse out the --noclose from the 
TerminalOptions and add a checkbox depending on the TerminalApplication

>
> - --
> David Faure -- faure at kde.org, dfaure at klaralvdalens-datakonsult.se

-- 
Simple things make people happy.
Willy De la Court