[PATCH] Re: KMix

[Christian Esken]

On Sunday 21 December 2003 23:03, Aaron J. Seigo wrote:
> On Sunday 21 December 2003 03:22, Christian Esken wrote:
> > why did you commit the patch? We had no consensus.
>
> because the patch sat for a couple days undiscussed? this is pretty common
> really, and happening with another patch of mine on this very list. there
> will be little to no actual discussion, but after it's committed there's
> immediately discussion =) i don't commit to create discussion, but i'm also
> not keen on waiting weeks for discussion that won't happen to occur.
>
> > And now you broke saving completely. Please fix it ASAP (either revert or
> > fix it).
>
> i must've missed it in the thread: what's broken completely? it works here,
> but perhaps i'm looking at the wrong thing, or have a different audio set
> up than you?

Volumes are not saved on exit. I can't say why, probably it works under some 
setups and on other not. You must test all cases, for example

- MainWindow hidden / MainWindow shown / MainWindow minmized (iconified)
- User allows KMix to use Systray / User does not allow to use Systray
- Quit via CTRL-Q / Quit via Close-Button / Quit via Logout

So this are 18 (3*2*3) possible setups. I am pretty sure you have not even 
tested one half of it (Hint: I do so with a test plan and currently it looks 
very bad).
Please see the "Problem with applications which have a system tray applet and 
secondary windows" thread to get one idea why saving might be so complicated.

And it is very bad that you cannot anymore restore the saved volume manually, 
for example after you have played with the Volumes and want to return to safe 
values. The option to restore volumes must never vanish.

Chris