[PATCH] kdeaddons/renamedlgplugins/audio/

[André Wöbbeking]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 15 December 2003 22:37, David Faure wrote:
> On Monday 15 December 2003 22:29, André Wöbbeking wrote:
> > From CopyJob::slotResultConflictCopyingFiles:
> >
> >         res = Observer::self()->open_RenameDlg( this,
> > m_conflictError == ERR_FILE_ALREADY_EXIST ? i18n("File Already
> > Exists") : i18n("Already Exists as Folder"),
> > (*it).uSource.prettyURL(0, KURL::StripFileProtocol),
> > (*it).uDest.prettyURL(0, KURL::StripFileProtocol), mode, newPath,
> >                               (*it).size, destsize,
> >                               (*it).ctime, destctime,
> >                               (*it).mtime, destmtime );
> >
> > I think, this should be changed to KUrl, maybe via an additional
> > RenameDlg ctor and KDE_DEPRECATED for the old ctor.
>
> I totally agree. This dialog was initially only showing those 2
> strings, so this was enough. Now that the URLs are passed to plugins
> that show previews etc., the job should definitely pass the KURLs. Go
> for it.

Does this have to wait til KDE 3.3?


André
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQE/3jRpGcp/AjG8ndYRApAeAJwN7mQoU/bwwhh57Tx8jjqIKBMpdACfX0z6
hBXj/bm7YZmWaRgrELE7l9E=
=lZGu
-----END PGP SIGNATURE-----