PATCH Re: [Bug 68744] Problems with accented characters in file names

[Dawit A.]

On Monday 15 December 2003 08:03, David Faure wrote:
> On Thursday 04 December 2003 00:23, David Faure wrote:
> > I'm for reverting that commit, which will fix the filenames problems,
> > but someone has to fix google queries then, probably in ikws.
>
> Here's the patch I posted to bug #64304 to fix this bug.
> The bug reporter verified it to work.
>
> However I wonder if autoWebSearchQuery() should also be modified the same
> way? 

Yes, it should.

> What does that one do? (I wouldn't mind a few comments in that 
> code...)

It is the engine used if you have selected a default search engine, i.e. 
anything other than 'None', and simply typed a phrase or word that is not a 
valid URL into konqueror's location bar. It is called from kuriikwsfilter.cpp 
which is the last filter invoked.

Hmm.. I think I see now why Malte attempted to fix the problem in KURIFilter 
instead of the plugins in the first place. KURIFilter has a ctor that accepts 
a KURL instead of a QString. Which means your patch only partially fixes the 
problem since an app can call the ctor that accepts the KURL and run into the 
problem described by this report.

-- 
Regards,
Dawit A.