[PATCH] kdeaddons/renamedlgplugins/audio/

David Faure dfaure at klaralvdalens-datakonsult.se
Mon Dec 15 09:13:32 GMT 2003

On Saturday 13 December 2003 13:43, André Wöbbeking wrote:
> Hi,
> while I tried to rip some songs from cd with the audiocd:/ ioslave, I
> found some issues.
> The patch to audio_plugin.cpp is to display the real file name (see also
> my other eMail "How to display file names").
> The patch to audiopreview.cpp is to use the right url.
> Both are needed as the given QString _dest is created from a KURL with
> prettyURL() and without my patch, the file name is encoded once more.

It is almost always wrong to call KURL::decode_string by hand.
fromPathOrURL was wrong too :)

I'm not very aware of the preview framework there - but if it passes a 
"QString filename" around, I assume that's the real filesystem filename,
so audio_plugin.cpp should use KIO::decodeFileName() before displaying it,
to decode %2F into '/'.

David Faure -- faure at kde.org, dfaure at klaralvdalens-datakonsult.se
Qt/KDE/KOffice developer
Klarälvdalens Datakonsult AB, Platform-independent software solutions

More information about the kde-core-devel mailing list