Fix for bug 67892

Oswald Buddenhagen ossi at
Tue Dec 9 03:05:18 GMT 2003

On Mon, Dec 08, 2003 at 06:49:03PM -0500, Ravikiran Rajagopal wrote:
> it is simply the code from
>      kdeutils/kdepasswd/userinfo/userinfo_chface.cpp
> which is known to work.
i wonder how ... when exactly did you test last time?

> PS: Both userinfo and ksplashml can benefit from the KUser class, but
> I have postponed it until past 3.2.
i don't consider the now relaxed freeze a convincing reason not to do
the transition ... :)

> +    // Keep in sync with kdeutils/kdepasswd/userinfo/userinfo_constants.h //
> +#define USER_FACE_FILE     "/.face.icon"   // The file in the user's home dir

> +#define USER_FACES_DIR     "/.faces/"      // User can install additional faces to ~/.faces/
> +
what's this for? it's not used, no?

> +#define SYS_DEFAULT_FILE   "/default1.png"  // The system-wide default image
outdated. KDM_FACES_DIR + ".default.face.icon"

> +#define KDM_FACES_DIR      "/pics/faces/"  // Directory where system-wide faces are stored (KDMDIR+this)
wrong. "/faces/"

> +#define KDM_USER_FACES_DIR   "/pics/users/"// Directory where kdm stores user pics (KDMDIR+this)
> +
outdated. now it's only kcm_kdm's image repository. don't use it.

> +#define FACE_PIX_SIZE      64              // Default Size for faces is 60x60
outdated. the display is now 48x48. but that's questionable (i think
i'll have to make it configurable) and the actual images are still
62x63 (yeah, what a stupid size ...).

> +#define FACE_BTN_SIZE      FACE_PIX_SIZE+10// Size for the Face button in the main dialog
> +
ugly. look what kcm_kdm does now.

> +    QString kdmDir = KGlobal::dirs()->resourceDirs("data").last() + "kdm/";
if you append the trailing slash here, you don't have to prepend one to
the constants above.

> +      userp = QPixmap( userPicsDir + username + ".png" );
outdated. ... + ".face.icon"


Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
Chaos, panic, and disorder - my work here is done.

More information about the kde-core-devel mailing list