[PATCH] libkcddb

[André Wöbbeking]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 08 December 2003 06:10, Aaron J. Seigo wrote:
> hi...
>
> read through the entirety of libkcddb this evening... the attached
> patch addresses the issues i caught; or at least the ones that should
> IMHO be fixed for 3.2 ... there are some minor things like multiple
> simultaneous submissions in async mode probably not working as
> expected, or the use of latin1() in some places; but those shouldn't
> have the same impact as things such as missing copy ctors and

the compiler generated methods should do the same (e.g. in TrackInfo and
CDInfo).

> operator=s for QValueList'd classes, or buffer underruns. anyways...
> pls review...

I don't know if the cddbplookup.cpp patch is correct.

In syncsmtpsubmit.cpp I don't understand the ! in

    if ( !KIO::NetAccess::file_copy( tmpUrl , url_ ) )
      return Success;


André
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQE/1RDkGcp/AjG8ndYRAn1MAJ95E/G6+SN7mj80F4xtKPNOEBsj2ACfU7Pt
M/y0FjmyJ00DbYRC7ehx18c=
=Zj/z
-----END PGP SIGNATURE-----