[PATCH] libkcddb

[Richard L㱫㭧]

On Monday 08 December 2003 06.10, Aaron J. Seigo wrote: 
> -----BEGIN PGP SIGNED MESSAGE----- 
> Hash: SHA1 
> 
> hi... 
> 
> read through the entirety of libkcddb this evening... the attached
patch 
> addresses the issues i caught; or at least the ones that should IMHO
be 
> fixed for 3.2 ... there are some minor things like multiple
simultaneous 
> submissions in async mode probably not working as expected, or the 
use of 
> latin1() in some places; but those shouldn't have the same impact as

things 
> such as missing copy ctors and operator=s for QValueList'd classes,
or 
> buffer underruns. anyways... pls review... 
 
Looks good to me except for this one: 
 
>      KURL tmpUrl; 
>      tmpUrl.setPath( tmp.name() ); 
> -    if ( KIO::NetAccess::file_copy( tmpUrl , url_ ) ) 
> + 
> +    if ( !KIO::NetAccess::file_copy( tmpUrl , url_ ) ) 
>        return Success; 
 
There's no docu for NetAccess::file_copy, but all other functions
seems to 
return true on success, and I get that feeling from a quick look at
the code 
too. 
 
Please commit everything but this one. 
 
Can't test submitting at all now though as smtp auth is broken for me
atm, 
have to send this from a webmail :-( 
 
Richard Lärkäng 
 
> 
> - -- 
> Aaron J. Seigo 
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 
DB43 
> "Never weary, never dispair, never give in" - Winston Churchill 
> -----BEGIN PGP SIGNATURE----- 
> Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux) 
> 
> 
iD8DBQE/1AfZ1rcusafx20MRAl0LAJ9HKRuoNjZFFG3otOh2/+BakokYAQCfaPiF 
> QzDeIXVLo7WLuvw6RTOts60= 
> =dQX4 
> -----END PGP SIGNATURE-----