[PATCH] KMix

[Aaron J. Seigo]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Saturday 06 December 2003 02:14, Christian Esken wrote:
> On Saturday 06 December 2003 07:00, Aaron J. Seigo wrote:
> > 1) don't show the "Current mixer:" set of widgets if there is only one

> Is on schedule for after KDE3.2. I believe wishlist items are not to be
> fixed anymore.

this is a usability bug, not a whislist item. in fact, it's a bug i fixed for 
3.1 and which has now been reintroduced for 3.2.

a wishlist item is a new feature, or a new behaviour. usability is not a 
wishlist; this doesn't introduce any new strings, is a trivial change and 
fixes a regression.

> BTW: Why does your patch exchanges QHBoxLayout by QHBox?

so that it is easier to hide them all at once... one call to hide() instead of 
several. and this way if/when you add or change the widgets in that area you 
don't have to change the code that hides/shows them.

> Your fix is outdated. Don't apply it. The code already does it correctly,
> because it references the mouse button which shows the volume slider
> (currently middle mouse button).

hrm.. ok... we still need to switch the left and middle button behaviour.

- -- 
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
"Never weary, never dispair, never give in" - Winston Churchill
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iD8DBQE/03Xj1rcusafx20MRAlNLAJ9SdDk3CapdSC8iesyoDL3Ixvew6ACfXCEC
0p2D0g+t6lf+rGZsL/VLJkA=
=PTqw
-----END PGP SIGNATURE-----