[PATCH] Re: KMix

[Frans Englich]

When speaking about 
minor-usability-patches-for-kmix-laying-around-on-the-hard-disc-for-ages, I 
have another one. It's against 3.1.4 and makes sure sound levels is always 
saved(see attachment). If there's any interest (at all) I could forward-port 
that 3-liner to head.

cheers,
Frans
-------------- next part --------------
From frans.englich at telia.com Sat Dec  6 20:16:20 2003
From: Frans Englich <frans.englich at telia.com>
To: kde-usability at mail.kde.org
Subject: [PATCH] KMix - always store sound levels as default
Date: Sat, 6 Dec 2003 21:16:20 +0200
User-Agent: KMail/1.5.1
MIME-Version: 1.0
Content-Disposition: inline
Status: RO
X-Status: Q
X-KMail-EncryptionState: N
X-KMail-SignatureState: N
Message-Id: <200307161526.53346.Frans Englich <>>
Content-Type: Multipart/Mixed;
  boundary="Boundary-00=_Esi0/w6Vyqg/0pK"


--Boundary-00=_Esi0/w6Vyqg/0pK
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi,

 Attached patch, against 3.1.1a makes KMix always save the volumes as default, the user does not have to select "Save Current Volumes as Default". Most users want their change to stay permanently and they get confused why the volumes has changed back on login. This makes it simpler and easier to use, especially for those from the Windows world where this setting is the behavior of their 'sound applet'(and it benefits not only former Windows users, this change is also better for the generic user).
When using the sliders the user gets feedback immediately which is IMHO very good, but requiring the user to use a "apply" mechanism doesn't follow the direct-maipulation paradigm use before. But that's what my patch fixes..

Also a simpler interface.

Any suggestions? (before I let the maintainer put it in the bit bucket.. or commit)

cheers!
Frans










--Boundary-00=_Esi0/w6Vyqg/0pK
Content-Type: text/x-diff;
  charset="us-ascii";
  name="kmix.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="kmix.diff"

--- kmix/kmix.cpp.orig	2003-08-28 05:41:39.000000000 +0200
+++ kmix/kmix.cpp	2003-08-28 05:42:32.000000000 +0200
@@ -150,10 +150,6 @@
 							 SLOT(newMixer()), actionCollection(), "file_new_tab" );
 	(void)new KAction( i18n("&Close Mixer Tab"), "fileclose", 0, this,
 							 SLOT(closeMixer()), actionCollection(), "file_close_tab" );
-	(void)new KAction( i18n("&Restore Default Volumes"), 0, this, SLOT(loadVolumes()),
-							 actionCollection(), "file_load_volume" );
-	(void)new KAction( i18n("&Save Current Volumes as Default"), 0, this, SLOT(saveVolumes()),
-							 actionCollection(), "file_save_volume" );
 	KStdAction::quit( this, SLOT(quit()), actionCollection());
 
 	// settings menu
@@ -530,6 +526,7 @@
 void
 KMixWindow::quit()
 {
+	saveVolumes();
 	kapp->quit();
 }
 
--- kmix/kmixui.rc.orig	2003-08-28 05:41:48.000000000 +0200
+++ kmix/kmixui.rc	2003-08-28 05:42:27.000000000 +0200
@@ -5,9 +5,6 @@
  <Menu name="file"><text>&File</text>
   <Action name="file_new_tab"/>
   <Action name="file_close_tab"/>
-  <Separator/>
-  <Action name="file_load_volume"/>
-  <Action name="file_save_volume"/>
  </Menu>
 </MenuBar>
 

--Boundary-00=_Esi0/w6Vyqg/0pK--