[PATCH] Fix animation timer leak on switching styles w/Keramik

Sandro Giessl ceebx at users.sourceforge.net
Tue Dec 2 20:50:43 GMT 2003


On Tuesday 02 December 2003 17:04, Maks Orlovich wrote:
> Hi...
> Do to a pretty major mental lapse on mine, Keramik forget to drop its
> animation timers when you switch style. As a result, switching
> between styles a lot in the kcm can cause a bit of a CPU drag. The
> attached patch fixes that, by using only a single one, and keeping
> track of progressbar livetime.
> Plastik has the identical issue, as it uses Keramik's animation code.
Yes, thanks for noticing.
> Please review..
As far as I can tell, the patch is fine.

I've adapted your patch to work with Plastik, could you please check?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: plastik_anim_timer.diff
Type: text/x-diff
Size: 2623 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20031202/309e78b0/attachment.diff>

More information about the kde-core-devel mailing list