[PATCH] Re: Style names

Waldo Bastian bastian at kde.org
Mon Dec 1 17:51:29 GMT 2003

Hash: SHA1

On Mon December 01 2003 15:48, Maks Orlovich wrote:
> On Monday 01 December 2003 08:02 am, Waldo Bastian wrote:
> > The Qt widget-styles are referred to as "Built-in" styles. I think that
> > is no longer true and also no longer relevant and I would like to remove
> > this from the descriptions.
> Yes, it's no longer true. Further, I think we may as well remove the
> description, leaving only the name, since none of the descriptions seem to
> be particularly helpful, and with the current kcm one can't see them w/o
> seeing a preview anyway.
> > Further there are the following descriptions which do not make a very
> > professional impression:
> > - Light Style, 2nd revision
> > - Light Style, 3rd revision
> > - B3/Modification of B2
> > - System Style 001
> >
> > The styles also refer to "themed" and "unthemed", it's unclear what is
> > meant with that and whether it has any relevance.
> >
> > I would like to clean up the descriptions later this week.
> Obviously, this is somewhat up to the i18n teams. However, one comment:
> whatever you do with Light* names, please make sure that the key name is
> similar to the .so name, since otherwise Qt wouldn't be able to guess what
> plugin to load right, causing it to potentially load all of them.

The attached patch:
* fixes translations by actually showing the translated name in the combobox 
instead of the internal id.
* Drops the description.
* It hides B3 (How is it different from KDE classic?)
* It hides Light v2 (I consider it superceded by Light v3)
* Renames System-Series to System (What about dropping one?)
* Drops "Qt" from all names that include that.

Please review.

- -- 
bastian at kde.org -=|[ SUSE, The Linux Desktop Experts ]|=- bastian at suse.com
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: styles.patch
Type: text/x-diff
Size: 4389 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20031201/c3e4ffb1/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kcmstyle.patch
Type: text/x-diff
Size: 5604 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20031201/c3e4ffb1/attachment-0001.patch>

More information about the kde-core-devel mailing list