Josef.Weidendorfer at gmx.de
Mon Sep 23 15:44:17 BST 2002
thanks for implementing this.
Unfortunately their are some problems with your patch:
- when deleting the recursive/watchFiles watch again, this only deletes the
given directory. It should delete all other added files watches, too.
- the "recursive" and "watchFiles" option has to be dynamic, otherwise
their is no use of implementing this in KDirWatch; your approach is static and
only looks for files existing when adding the watch.
E.g. if a file is created in directory of a watch entry with option
"watchFiles", it should automatically be watched, too. And of course deleted
with the original entry. Same holds for the "recursive" flag.
Before release of KDE 3.0, I added these flags, and started implementing
something, but I didn't finished...
BTW: Main use of the "recursive" flag would be in KDED, where recursive dirs
are watched. Every time KDED detects a change, it deletes ALL watches and
creates them again. This is much overhead for nothing. In KDirWatch, this
could be done VERY efficient...
I'm waiting for your next patch :-)
Only problem with this patch:
On Sunday 22 September 2002 01:59, Otto Bruggeman wrote:
> this patch implements the code for the parameters watchFiles and recursive
> of addDir in KDirWatch, i hope i did it the right way. Anyway i know it is
> a bit late for 3.1 so i dont expect it to go in but i would like your
> opinion about the patch anyway.
More information about the kde-core-devel