kdebase/kdm/chooser

[Oswald Buddenhagen]

On Thu, Sep 12, 2002 at 10:13:37PM +0200, Martijn Klingens wrote:
> On Thursday 12 September 2002 21:58, Oswald Buddenhagen wrote:
> > no :}
> > setCrashHandler is not covered. also, you have no way to reset it.
> > so this proper solutions looks like overkill to me ...
> 
> I take it you use your 'hack' then? :-)
> 
well, i'd prefer the kde_use_kcrash hack or the
KApplication::disableKCrashInstallation() public api extension (for the
purists :). i would happily go with the hack, as it has the smallest
overhead - probably nobody else will ever use it anyway.
the attached patch should do it. but i will change the *_have_* in
*_use_* before the actual commit, i think.

greetings

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Chaos, panic, and disorder - my work here is done.
-------------- next part --------------
Index: kapplication.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdecore/kapplication.cpp,v
retrieving revision 1.519.2.2
diff -u -r1.519.2.2 kapplication.cpp
--- kapplication.cpp	2002/07/25 19:42:15	1.519.2.2
+++ kapplication.cpp	2002/09/12 23:27:00
@@ -141,6 +141,7 @@
 #include "kappdcopiface.h"
 
 bool kde_have_kipc = true; // magic hook to disable kipc in kdm
+bool kde_have_kcrash = true; // magic hook to disable kcrash in kdm
 
 KApplication* KApplication::KApp = 0L;
 bool KApplication::loadedByKdeinit = false;
@@ -1323,8 +1324,7 @@
        }
     }
 
-    bool nocrashhandler = (getenv("KDE_DEBUG") != NULL);
-    if (!nocrashhandler && args->isSet("crashhandler"))
+    if (kde_have_kcrash && !getenv("KDE_DEBUG") && args->isSet("crashhandler"))
     {
         // set default crash handler / set emergency save function to nothing
         KCrash::setCrashHandler(KCrash::defaultCrashHandler);