[Patch] Re: KDockWidget'S

[Christoph Cullmann]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 10 September 2002 19:38, Andreas Zehender wrote:
> Hi!
>
> On Tuesday 10 September 2002 19:12, Lubos Lunak wrote:
> >  I guess we need a new rule in the keep-BC paper, saying that classes
> > willing to stay BC shouldn't have inline destructor.
> >
> >  You can destroy the private data by inheriting class
> > KDockWidgetHeader::KDockWidgetHeaderPrivate from QObject and passing the
> > KDockWidgetHeader instance that created it as its parent (so it will
> > delete it automatically). *shrug*
> >
> >  BTW, if you want, you can just use KDockWidgetHeaderPrivate instead of
> > KDockWidgetHeader::KDockWidgetHeaderPrivate , if you move the forward
> > declaration out of the class (lazy people ... including me :-/  ). It
> > won't break BC, the 'd' member is just a pointer.
>
> This new patch fixes the inline constructor issue and should be now fully
> binary conpatible.
>
> Can I commit?
Have no probs with your stuff, but why does we need a undock button ? 
Shouldn't we make it the qdockwidget style to undock on double click on the 
drag handle ? (And dock back by double click, too)
Would than be in sync with the rest of kde (as toolbars, qdockwidgets, ...)

cu
Christoph

- -- 
Christoph "Crossfire" Cullmann
Kate/KDE developer
cullmann at kde.org
http://kate.kde.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9fk0AyPjDGePm9UIRAq8gAKCEoHnaOFkbcAlpONAcVwBnmeznjgCdHOuL
ElJJgxiiIcjfw/n1n7UJvb4=
=j42z
-----END PGP SIGNATURE-----