[PATCH] Style fix for kdesdk/kapptemplate/kpartapp
david at mandrakesoft.com
Tue Sep 3 08:58:36 BST 2002
-----BEGIN PGP SIGNED MESSAGE-----
On Tuesday 03 September 2002 09:42, Thomas Zander wrote:
> On Tuesday 03 September 2002 09:28, Dominique Devriese wrote:
> > Hi,
> > since i don't seem to be getting any replies to this on kde-devel,
> > i'll try again here.
> > I have found what I believe to be a style guide bug in the
> > kapptemplate template for kpartapp. The problem is with the file_open
> > action. If I understand the Style Guide correctly, this should open a
> > new windows showing the document, instead of closing the old document,
> > and opening the new one instead in the same window. I'm including an
> > patch for this. I have tested the patch, and it works fine for me.
> > I appreciate any comments.
> > cheers
> > domi
> File "new" does what you say, not file "open".
> I think you confused them.
In KOffice we have the notion of an "empty" document. If the current document
is empty (e.g. create by File/New), then we replace it with the new one.
Otherwise file/open creates a new window.
And the styleguide goes that way too. Quote from the above URL:
"If the application is NOT in the initial state and the user opens a new document
by selecting either New or Open in the File-menu, then a new application is
started in which the document is loaded. "
"Initial state" maps very well to what I called "empty" [which isn't necessarily
completely empty, when the template has text :)].
David FAURE, david at mandrakesoft.com, faure at kde.org
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KOffice-1.2-rc1 is out. ftp://ftp.kde.org/pub/kde/unstable/koffice-1.2-rc1/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org
-----END PGP SIGNATURE-----
More information about the kde-core-devel