PATCH to make minicli use all KURIFilterPlugins

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 28 October 2002 06:16, Dawit A. wrote:
> > However this API does prevent running any other plugin, and a better
> > API for this case would be "run all plugins except those". This would
> > require a change in KURIFilterData, but is the only right way to do this.
> 
> No it is not the only choice.  It is one of the choices :)  The restriction in 
> minicli was temporary.  I intended to come up with a config dialog that 
> allows you to select the plugin you desire.  However,  I have never gotten 
> around to doing it for several reason one of which is that the config dialog 
> needs to be available to all apps that use it and save its settings into the 
> specific apps config file.  This way the plugins used for konqueror would not 
> be mixed up with the once in Minicli for example.
> 
> There is also no good reason to ban everyone from using any plugin they choose 
> so long as the default setting is as sane as it is now :)

Sorry, but I think this is over-configurability.
The fact that someone should be able to disable some features (say, ikws,
or maybe localdomainfilter, in case of network problems) is ok, but there is 
really no point in being able to disable the search-engines one (just don't 
type gg:blah (*)) or the short-uri-filter one (just don't type short uris ;).
Well that one does many things, maybe some can be disabled, but not all
(e.g. #man and ##info are explicit, ~ and $envvar too.....)

(*) : duh, why do we have a checkbox in "kcmshell ebrowsing" ?

Anyway, if both the app and the user can choose which plugins to use,
this is a good way to enter maintainance nightmare and tons of bugs
("I selected this plugin but the app refuses to run it", or "I disabled this
plugin and now this (which looks unrelated) doesn't work anymore") etc.

Neil wrote:
> I figure the easiest
> stopgap solution is to use the existing filter iterator to produce a
> QStringList of all installed filters.  Then remove ikws, and we're happy.

Yes - and remove localdomainurifilter if !final.
So the best would be to do that iteration once on start, and store the two
QStringLists, ready to use for parseLine(). I'd happily approve a patch doing that ;)

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9vQgD72KcVAmwbhARAhs7AJ9tywAltekjTl9sEvXRJx4xhiL4cgCgmeLS
+gek35qXiOl6B5CIp6VQCkE=
=1Kvf
-----END PGP SIGNATURE-----