problem with KToggleToolBarAction (+patch)

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 25 October 2002 20:34, Simon Hausmann wrote:
> 1) We could make setChecked less intelligent. I guess the original idea behind
> the current setChecked implementation was to make things easier for developers
> calling setChecked explicitly. To still update the toolbar visibility status
> when the user activates the corresponding 'Show Foo Toolbar' menu item we could
> simply call setShown() on the toolbar in slotActivated() . This solution is
> implemented in kaction2_patch.txt

Yes, it's wrong that setChecked(bool) activates some changes, it should only
check or uncheck the action. Remember that we removed "emit activated"
from setChecked in KToggleAction. The hiding/showing of the toolbars should
only happen when the _user_ activates the action, not when setChecked() is called.

> Solution 1 could possibly break third-party apps that rely on setChecked
> basically causing the activation on the action (-> showing/hiding the toolbar)

Those would need to be fixed. Did this action exist in 3.0?

PS: Solution 1 is kaction2_patch.txt and solution 2 is kaction1_patch.txt? How confusing ;)

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9ubuq72KcVAmwbhARAuy0AKCotF4oSv0wRvnAjzMGwEatGyahEQCeMSBU
eJGGr/FfSZdYn9DbgLCHfUs=
=ceq/
-----END PGP SIGNATURE-----