KDirWatch (Re: problem with KIO::NetAccess and KDirLister/KFileTreeView)

[Josef Weidendorfer]

On Tuesday 15 October 2002 14:18, David Faure wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> > First for the backtrace: Is it right to say there's a SEGFAULT in
> > "QPtrList<KDirWatchPrivate::Client>::next"?
>
> Yes.
>
> > We have to make this "delayRemove" more general, not only for
> > "slotRescan". (Michael Brade only used the STAT method and sent me these
> > kind of bugs. So only STAT got stable :-)
>
> I'll send you the FAM problems I see, no problem ;)
>
> > Nevertheless, can you try the attached patch ?
>
> Seems to work here.
> Well, I didn't test before, how reproduceable the crash was. But at least
> I can't reproduce it with this patch (and I tried valgrind'ing, no problem
> shown).

Fine. That was the answer I expected :-)
I think you should commit this patch before KDE 3.1 release if you think you 
did enough trying to reproduce the crash. After all: I recognized a bug and 
fixed that one - even if it would be not the one you were observing...

A saw the lines you added because KView does show a MessageBox in a slot 
called from KDirWatch.

Shouldn't this be changed in KView? Switching off the STAT timer in KDirWatch
is only a hack specific for STAT... If I implement delayed signal emitting, 
further signals can't be stopped this way.
The right thing to do here is stopping the watching and restarting again after 
the MessageBox is closed. Of course we will NEED the restarting method to NOT 
throw away pending events (See my last proposal for this one...).
Or a better approach: Temporary stop watching when emitting a signal...
Then the application has nothing to do.

For delayed signal emitting, I need an KDirWatchPrivate::Entry to store 
pending events. This means I have to implement "watchFiles" before - 
otherwise I would have to disable the automatic file watching of directories 
with FAM :-(

I hope I have time for these things before KDE 3.2 :-)
... or somebody provides the right patch.

Josef


>
> - --
> David FAURE, david at mandrakesoft.com, faure at kde.org
> http://people.mandrakesoft.com/~david/
> Contributing to: http://www.konqueror.org/, http://www.koffice.org/
> Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.0.7 (GNU/Linux)
>
> iD8DBQE9rAd872KcVAmwbhARAtr8AJ0c2DIVaZcQsIlbmwRlzEkLviMXqwCgmavW
> gPZIQrS/jIkv2EWVctUCX5I=
> =srXy
> -----END PGP SIGNATURE-----