PATCH: some fixes for global shortcuts

[Lubos Lunak]

On Saturday 12 October 2002 17:16, Ellis Whitehead wrote:
> On Thursday 10 October 2002 11:28, Lubos Lunak wrote:
> > On Wednesday 09 October 2002 21:23, Ellis Whitehead wrote:
> > > Hi Lubos,
> > >
> > > On Wednesday 09 October 2002 18:08, Lubos Lunak wrote:
> > > >  Hello,
> > > >
> > > >  please review the attached patch. It allows "moving" a global
> > > > shortcut in kcontrol without having to restart it (e.g. you cannot
> > > > now use Alt+F2, it will complain even if you unset it for 'Run
> > > > Command'). Also, it has the nice side-effect of all KKeyChoosers
> > > > updating the global shortcuts automatically, so now when configuring
> > > > some app's shortcuts, and there's a conflict against some global
> > > > shortcut, one can start kcontrol, disable the global one and continue
> > > > in the app's dialog without having to close and reopen it.
> > >
> > > Excellent. ;)  I wouldn't want globalChoosers to be defined in the
> > > public header file, though.  Could you move it to kkeydialog.cpp?
> >
> >  It wasn't supposed to be in the protected: part, it was meant to be
> > private, so having it in .h wouldn't be any problem. But I moved it if
> > you like it better that way. Commited.
>
> Using your patch, KControl locks up on me now when I try to make a key
> assignment.  If I revert, it works again.  You're not having this same
> problem?  Most of my local cvs copy is about 2 weeks old, so maybe the
> problem lies there...

 Hmm ( ... where's the backtrace? ). The attached patch should fix the 
infinite loop (isKeyPresent() called isKeyPresent() which called ...).

 BTW, why is all that stuff protected: in the class?

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kkeydialog.cpp.patch
Type: text/x-diff
Size: 2213 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20021014/a2c0f749/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kkeydialog.h.patch
Type: text/x-diff
Size: 705 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20021014/a2c0f749/attachment-0001.patch>