More patches for approval..

[Oswald Buddenhagen]

On Thu, Oct 10, 2002 at 02:08:37AM -0700, Alex Zepeda wrote:
> --- kdm/kfrontend/genkdmconf.c.orig	Wed Jun 26 12:37:51 2002
> +++ kdm/kfrontend/genkdmconf.c	Wed Jun 26 12:39:42 2002
> @@ -402,7 +402,7 @@
>  "# by Xsetup usually.\n"
>  "# This is not required if you use PAM with the pam_console module.\n"
>  "#\n"
> -"#chown $USER /dev/console\n"
> +"chown $USER /dev/console\n"
>  "\n"
>  #ifdef _AIX
>  "# We create a pseudodevice for finger.  (host:0 becomes kdm/host_0)\n"
>
> @@ -443,8 +443,8 @@
>  "# Reassign ownership of the console to root, this should disallow\n"
>  "# assignment of console output to any random users's xterm. See Xstartup.\n"
>  "#\n"
> -"#chown root /dev/console\n"
> -"#chmod 622 /dev/console\n"
> +"chown root /dev/console\n"
> +/* "#chmod 622 /dev/console\n" */
>  "\n"
>  #ifdef _AIX
>  "if [ -f /usr/lib/X11/xdm/sessreg ]; then\n"
>
i don't think this is a good idea. this will probably interact badly
with quite some pam based systems.

> @@ -1054,7 +1054,7 @@
>  { "Language",		"de_DE", 0 },
>  { "ShowUsers",		"None", 0 },
>  { "SelectedUsers",	"root,johndoe", 0 },
> -{ "HiddenUsers",	"adm,alias,amanda,apache,bin,bind,daemon,exim,falken,ftp,games,gdm,gopher,halt,httpd,ident,imnadm,ingres,kmem,lp,mail,mailnull,man,mta,mysql,named,news,nfsnobody,nobody,nscd,ntp,operator,pcap,pop,postfix,postgres,qmaild,qmaill,qmailp,qmailq,qmailr,qmails,radvd,reboot,rpc,rpcuser,rpm,sendmail,shutdown,squid,sympa,sync,tty,uucp,xfs,xten", 1 },
> +{ "HiddenUsers",	"adm,alias,amanda,apache,bin,bind,daemon,exim,falken,ftp,games,gdm,gopher,halt,httpd,ident,imnadm,ingres,kmem,lp,mail,mailnull,man,mta,mysql,named,news,nfsnobody,nobody,nscd,ntp,operator,pcap,pop,postfix,postgres,qmaild,qmaill,qmailp,qmailq,qmailr,qmails,radvd,reboot,rpc,rpcuser,rpm,sendmail,sshd,shutdown,smmsp,squid,sympa,sync,tty,uucp,www,xfs,xten", 1 },
>  { "MinShowUID",		"1000", 0 },
>  { "MaxShowUID",		"29999", 0 },
>  { "SortUsers",		"false", 0 },
>
errm ... when did you last update the sources??? jun 26?!? my god ... ;)

> --- kdm/backend/xdmcp.c.orig	Wed May  8 14:21:31 2002
> +++ kdm/backend/xdmcp.c	Wed Jun 26 20:14:02 2002
> @@ -1012,7 +1012,7 @@
>  
>      sprintf (buf, "Session %ld failed for display %.260s: %s",
>  	     (long) sessionID, name, reason);
> -    Debug ("send_failed(%\"s)\n", buf);
> +    Debug ("send_failed(\"%s\")\n", buf);
>      status.length = strlen (buf);
>      status.data = (CARD8Ptr) buf;
>      header.version = XDM_PROTOCOL_VERSION;
>
this part is plainly wrong. see printf.c:47.

bottom line: all rejected. :}

greetings

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Chaos, panic, and disorder - my work here is done.