[PATCH] Ghost Shadows

[Malte Starostik]

On Tuesday 08 October 2002 05:23, Malte Starostik wrote:
> On Saturday 05 October 2002 11:45, Till Krech wrote:
> > Hi,
>
> [snip]
>
> > The problem is that the QPopupmenu gets two QEvent:Show events.
>
> This modification to qapplication_x11.cpp introduced the double show
> events: case MapNotify:                            // window shown
> -       if ( widget->isTopLevel() && !widget->isVisible()
> -            && !widget->isHidden() ) {     widget->setWState(
> WState_Visible );
> -           widget->sendShowEventsToChildren( TRUE );
> +       if ( widget->isTopLevel() ) {
> +           widget->showChildren( TRUE );
>             QShowEvent e;
>             QApplication::sendSpontaneousEvent( widget, &e );
>         }
>
>  Attached patch tries to fix it, but I'm not too sure about the
> implications. Could it be that this part of the condition was removed
> accidentally?
Sorry, a bit too fast. The && !widget->isHidden() part seems needed as well, 
after readding it, the spurious show events after hiding popup menus 
disappear as well.

Regards,
-Malte