Fix for Bug 45195: Cannot close terminal emulation with Ctrl+D anymore (major)

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 01 October 2002 17:29, Ellis Whitehead wrote:
> On Tuesday 01 October 2002 17:08, Oswald Buddenhagen wrote:
> > On Tue, Oct 01, 2002 at 04:56:12PM +0200, Ellis Whitehead wrote:
> > > This means that Ctrl+D will always be overridden when TEWidget has the
> > > keyboard focus, no matter what program it's embedded in.
> >
> > i don't like the idea that you limit this to ctrl-d. about any
> > ctrl-<key> should be passed through.
> 
> The important question for me is whether any accels should be overridden at 
> all. 

Yes, I definitely agree that they should.
The key event should go to the focus widget first (here the konsole part,
and in case of Ctrl+D it should catch it). The mainwindow stuff should only
be looked at afterwards, for shortcut not handled by the focus widget.

> If so, this patch can go in, and it would be no problem to make the 
> accel override apply more broadly.

I'm not sure how, but I'd like this to be much more general, somehow:
any widget should be able to catch shortcuts before the mainwindow sees them.
It looks like this means we have to use AccelOverride almost everywhere,
in parts and widgets ?

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9mcJt72KcVAmwbhARApTpAJ91Hb4ElqrJFtCcrYSruYdO5RMXZACfSf78
gd1rMbnp9/Qb8QQlLHG1bag=
=Q9ap
-----END PGP SIGNATURE-----