[PATCH] fix line edit in ksirc

[Simon Hausmann]

On Sat, Nov 23, 2002 at 01:20:41AM +0100, Ellis Whitehead wrote:
> On Friday 22 November 2002 19:29, George Staikos wrote:
> > On Friday November 22 2002 05:15, Simon Hausmann wrote:
> > > On Fri, Nov 22, 2002 at 12:54:28AM -0500, George Staikos wrote:
> > > > This patch fixes the lineedit problems I have been seeing in ksirc for
> > > > quite some time now.  Shift+Backspace was erasing two characters
> > > > instead of one. This fixes it for me.
> > > >
> > > > Ok to apply?
> > >
> > > I think that's a workaround for the real bug: the lineedit receives
> > > multiple accel events for any shift key combination. It's the same
> > > for shift-left/right for example, and gdb/debug output show the
> > > same. I remember that this was caused through the global event filter
> > > changes in kaccel, for which Ellis also applied a fix to solve this
> > > very problem. But it appears it works only for key events without
> > > modifiers. Ellis, any idea?
> >
> >   Well I think that if we don't get a fix asap, we should commit a
> > workaround for all the known key problems and deal with the real fix after
> > 3.1.0.
> 
> ksirc's method of handling accelerators is very strange.  When I looked at the 
> code a month or so ago, it seemed like the fact that it worked at all must be 
> due to a bug in Qt somewhere. *grin*  I'll check it out again tomorrow to see 
> what I can do...

I very much agree that this part of ksirc's code is pretty fishy,
but I guess asj had his reasons. In any case I don't feel like
changing the code not to catch the accel events at this stage. I'd
be happy to okay George's workaround if the real bug does not get
forgotten (i.e.  someone files a bugreport) .


Simon