KRun Breakage (+Kate patch)

Christoph Cullmann cullmann at babylon2k.de
Mon Nov 18 21:44:20 GMT 2002


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 18 November 2002 10:31, Waldo Bastian wrote:
> On Monday 18 November 2002 02:04, Ryan Cumming wrote:
> > Next, kfmexec downloads the remote file and runs Kate. However, it seems
> > to think Kate has exited before it has even finished starting up. This
> > causes kfmexec to remove the temporary file before Kate has a chance to
> > read it. The result is Kate showing a blank file. This second bug seems
> > like a bad KUniqueApplication interaction.
>
> It's a bug in kate actually. Normally KUniqueApplication::newInstance()
> gets called and only when this function returns does the process that was
> started return. Kate should load the files passed on the command line in
> newInstance(). But it delays the call to newInstance to later, which breaks
> things.
>
> It would probably work if Kate would delay the call to newInstance by
> using: kapp->dcopClient()->suspend(); // Don't handle DCOP requests yet
> and
> 	kapp->dcopClient()->resume(); // Ok. We are ready for DCOP requests.
> as done by KMail.
>
> That should replace m_noEventLoop.
>
> Patch attached, seems to work just fine.
Looks better than the old hack ;) Please commit.

>
> Cheers,
> Waldo

- -- 
Christoph Cullmann
Kate/KDE developer
cullmann at kde.org
http://kate.kde.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE92V82yPjDGePm9UIRAjRLAJ0XXHJWkWsfV2Sy+9sDAutrlRpGJACglh7F
zbRx9jYqWMX54v3pCv62f/c=
=XEzN
-----END PGP SIGNATURE-----





More information about the kde-core-devel mailing list