[PATCH] unsafe /tmp usage of kmailcvt

Waldo Bastian bastian at kde.org
Sun Nov 17 21:15:39 GMT 2002


On Sunday 17 November 2002 18:32, Ingo Klöcker wrote:
> > THIS PATCH STILL NEEDS TESTING! Specifically, someone with an outlook
> > express 4.2 (?) and/or 5.2 (?) mail folder should test whether
> > kmailcvt can still import them into kmail.
>
> I guess you are aware of the fact that your patch changes some
> translated texts. Is this really necessary? Can't you reuse the old
> texts? I see no reason to change e.g.
>   "FATAL: Cannot open TEMP file '%1'"
> to
>   "FATAL: Cannot open temporary file.".

If I can't create a temp file I don't have a name either. I can't replace %1 
with anything meaningful.

> Apart from that the patch looks OK. I haven't tested it though.

Still waiting for someone to do that then.

Cheers,
Waldo



More information about the kde-core-devel mailing list