KMail folder changing bug [Issue N9282] (Was: Re: KDE 3.1: one week delay)

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 11 November 2002 17:04, Roger Larsson wrote:
> On Monday 11 November 2002 16.28, George Staikos wrote:
> > On Monday November 11 2002 09:50, Roger Larsson wrote:
> > >
> > > > Do you think maybe we should get together a list of bugs considered
> > > > "showstoppers" so they can be analysed?
> > >
> > > Could you and others please retest if you can reproduce the bug
> > > in the same way as I do it - it is 100% reporduceable for me?
> > > 	http://bugs.kde.org/show_bug.cgi?id=48888
> > > (I think it has a lot to do with drag and autoscroll...)
> > >
> > > Can someone (else?) put it as CONFIRMED?
> > 
> >   David Faure actually had a patch for it, but it doesn't seem to be in 
> > qt-copy (or it is insufficient).  I think this is the same thing as what you 
> > describe though.
> > 
> 
> Where can I find that patch? I am more than willing to try it.

Well my patch is simply:
- --- qlistview.cpp       2002/10/30 10:59:36     1.48
+++ qlistview.cpp       2002/11/11 17:46:18
@@ -4454,8 +4454,6 @@ void QListView::contentsMouseMoveEvent(
            delete d->scrollTimer;
            d->scrollTimer = 0;
        }
- -       // call this to select an item
- -       doAutoScroll();
     }
 }

However I guess there's a reason for that call (although the comment makes
no sense to me), so maybe this patch breaks something - I'd be curious to
find out why, though.

> But I got the impression from trolltech that they had a proper fix that were 
> going into qt final

By going back in qt-copy's CVS, I saw that the previous version of qlistview.cpp
had a new member var (in the d pointer of course) to remember the position
of the mouse, between contentsMouseMoveEvent and doAutoScroll, which is
another possible fix. However this change got reverted in a later version of Qt,
I don't know why.

> It might also be that kmail does something strange...
> It differs from the qt listviews example by using currentChanged on folders,
> instead of slotFolderChanged. And as far as I can tell the listviews example
> works [qt-copy/examples/listviews/listviews], even with added sleeps...

Hmm. I think doAutoScroll() using QCursor::pos() is the bug, (or the fact that
doAutoScroll() is called from contentsMouseMoveEvent in the first place),
no matter what the application does.

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9z+4z72KcVAmwbhARAlyYAKCp1F4/3nGhpr1dZBdhZDRQ+HNdywCeOjXI
daMYH5ulLUDcpgleEZho148=
=YNJH
-----END PGP SIGNATURE-----