Fwd: Patch for KJanusWidget problem

Martijn Klingens klingens at kde.org
Sat Nov 9 12:12:12 GMT 2002


Could someone who knows KJanusWidget look at this patch?

To me it looks fine, although it might be better to simply fix the problem at 
the Qt level.

Martijn

----------  Forwarded Message  ----------

Subject: Patch for KJanusWidget problem
Date: Saturday 09 November 2002 04:08
From: Ravikiran Rajagopal <ravi at ee.eng.ohio-state.edu>
To: Martijn Klingens <klingens at kde.org>

Hello,
  Could you please forward this to kde-core-devel? This provides a workaround
for a Qt-copy buglet in QWidgetStack. QWidgetStack does not seem to
automatically remove its members which have been deleted. This can be
achieved manually by the patch. Further, this patch is innocuous because (as
I understand it) QWidgetStack::removeWidget does not do anything if the
requested widget is not in the stack. This patch is for kdelibs HEAD.

Thanks,
Ravi

--- kdeui/kjanuswidget.cpp.orig       2002-11-08 22:05:04.000000000 -0500
+++ kdeui/kjanuswidget.cpp    2002-11-08 22:04:25.000000000 -0500
@@ -246,6 +246,7 @@
          {
         delete i.key();
         mTreeListToPageStack.remove(i);
+       mPageStack->removeWidget((const_cast<QWidget*>(page)));
                break;
       }
   }

-------------------------------------------------------





More information about the kde-core-devel mailing list