[PATCH] fix #47996

[Josef Weidendorfer]

On Thursday 07 November 2002 12:58, David Faure wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Thursday 07 November 2002 12:43, Michael Brade wrote:
> > On Thursday 07 November 2002 11:33, Waldo Bastian wrote:
> > > I think this should eventually be handled in KDirWatcher,
> >
> > LOL, it's KDirWatch :-)
> >
> > > possibly with an increasing backoff-period. (After 3.1)
> >
> > So, what now, commit and revert after KDirWatch is fixed or wait for 3.2?
> > I'd like to fix it for 3.1 as well, even if we change the implementation
> > later.
>
> IMHO we need this fix, whichever way it's done for 3.1.
> If your KDirLister change works :), I suggest you go ahead and commit it.

Yes. Commit it please.

I think I have enough time to implement the "watchFiles" and "recursive" flags 
for KDirWatch::addDir() for KDE 3.2, as well as the event merging and 
emitting. This HAS to be done in KDirWatch.
But if you commit your changes, I want feel that forced to implement it for 
KDE 3.1 ;-)

BTW, why do you get that many events from FAM? I don't understand it.
Of course when a program writes a large file, and DNOTIFY is used in FAM, you 
will get a signal for every write() system call for that file :-(

Regarding the little number of signals in KDirWatch:
I don't feel guilty. When I introduced explicit file watching before KDE 3.0, 
I added separate signals. Short before the KDE 3 API freeze it was decided to 
unify the signals for simplified usage. Obviously this was the wrong 
decision.

Do you know a BC way to add signals?
I could add non-virtual functions with receiver/slot arguments which connect 
to signals of KDirWatchPrivate...

For KDE 4: Do you think it has an advantage to have a "fileExists" signal, 
emitted for all existing files in a directory after a addDir() ?
I get these from FAM, and once "watchFiles" is implemented, it is easy to 
generate the signals in STAT/DNOTIFY mode, too.

Josef
>
> - --
> David FAURE, david at mandrakesoft.com, faure at kde.org
> http://people.mandrakesoft.com/~david/
> Contributing to: http://www.konqueror.org/, http://www.koffice.org/
> Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.0.7 (GNU/Linux)
>
> iD8DBQE9ylVX72KcVAmwbhARAjiZAKCqqXRbEMWDWqL3lOsJTIccvoP4ewCdGmWv
> NBKB7stp+Qsab2hOKL8/CTE=
> =32Nu
> -----END PGP SIGNATURE-----