[PATCH] fix rename crash in Konqy

John Firebaugh jfirebaugh at kde.org
Mon Nov 4 07:38:27 GMT 2002


On Sunday 03 November 2002 1:59, Michael Brade wrote:
> Hi!
>
> Somehow I have the feeling almost nobody knows how KDirLister works :-\ The
> attached patch essentially reverts AleXXX hack^Hcommit from 5 months ago,
> removing the renamingFinished() method in KonqBaseListViewWidget and
> KonqIconViewWidget. In combination with John's patch (which nobody seems to
> have tested) it crashes Konqy.
>
> Here's why: if the renaming succeeds KDirLister will emit deleteItem() and
> newItems(). So in the listview's renamingFinished() m_renamedItem is not 0,
> but a dangling pointer and the call to m_renamedItem->updateContents() is
> the reason for the crash.
>
> In general, if after renaming a file with F2 the file is shown with a wrong
> name it is the fault of KDirLister not emitting the correct signal or a bug
> in the implementation of the slots connected to its signals.

Ah, ok. Patch looks good then -- nice that we can simplify it.

-John




More information about the kde-core-devel mailing list