[PATCH] fix rename crash in Konqy

David Faure david at mandrakesoft.com
Sun Nov 3 23:19:07 GMT 2002


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 04 November 2002 00:05, Michael Brade wrote:
> No, not anymore. That's what I ment with "correct part of John's patch" and 
> the comment starting with
> // The correct behavior is to show ...
> says. Did you actually read the patch? ;-))

Ah, now I see. I was stupidly sure that your patch didn't handle this case,
because it removes the whole code for it (the signal and slot etc.), and at the
time it seemed that it was the only possible solution.... But indeed if KDirWatch
does its job, then the renaming will appear to the user when it succeeds.....
so this whole thing isn't needed.

> > Now I'm a bit confused as to what John's patch was, and what AleXXX's patch
> > was, and... whether your patch fixes the above case - I guess not, since it
> > removes most of the fix for it?
> No, see above. Works fine for me, I even valgrinded it right now to be 100% 
> sure. If you can try it without FAM (renaming it to an empty file, to a valid 
> name or to an already existig file), that would be cool.

Actually, you can simply kill the fam daemon to make konqueror revert
to stat() polling :). Ok, I'll test this once you commit it - it does look ok
to me now.

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9xa7s72KcVAmwbhARAqaCAKCf14emlBWZwcHomlSg4gJjzLo34QCgilco
hK2LkGrOWYXpoWS2/T9vLmY=
=g0JL
-----END PGP SIGNATURE-----





More information about the kde-core-devel mailing list