[PATCH] fix rename crash in Konqy

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 03 November 2002 22:59, Michael Brade wrote:
> Hi!
> 
> Somehow I have the feeling almost nobody knows how KDirLister works :-\ The 
> attached patch essentially reverts AleXXX hack^Hcommit from 5 months ago, 
> removing the renamingFinished() method in KonqBaseListViewWidget and 
> KonqIconViewWidget. In combination with John's patch (which nobody seems to 
> have tested) it crashes Konqy.
> 
> Here's why: if the renaming succeeds KDirLister will emit deleteItem() and 
> newItems(). 

But IIRC this happens after the refreshItems signal, coming from FileRenamed?
Maybe this would provide a solution to this problem?

(I realize that my testing might have been done without fam, so maybe KDirLister
got the events later than with fam..... Just a guess.)

> In general, if after renaming a file with F2 the file is shown with a wrong 
> name it is the fault of KDirLister not emitting the correct signal or a bug 
> in the implementation of the slots connected to its signals.

No, the initial problem, for which this whole thing was done, is:
if you rename the file to the name of a file that already exists, you get the
"rename/overwrite/skip dialog", then if you choose cancel, the iconview (or listview)
will keep showing the new name.
At the KDirLister nothing happens. But the iconview/listview shows the new
name right away, before the actual renaming operation, hence the problem.

Now I'm a bit confused as to what John's patch was, and what AleXXX's patch
was, and... whether your patch fixes the above case - I guess not, since it
removes most of the fix for it?

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9xaL572KcVAmwbhARArF5AKCmedUlOzwzo8v0q5278mfbE5brJgCffBcx
Q5Jx045ve5euR9I3B7B5GLo=
=S1Tz
-----END PGP SIGNATURE-----