[PATCH] KToolBarMenuAction fix for single toolbar

Joseph Wenninger jowenn at bigfoot.com
Wed May 29 18:47:40 BST 2002


Hi

On Wednesday 29 May 2002 14:58, Nadeem Hasan wrote:
> On Tuesday 28 May 2002 11:21 pm, Nadeem Hasan wrote:
> > Hi,
> > The following patch fixes a problem with toolbar show/hide menu
> > generation with KToolBarMenuAction when the KMainWindow has only one
> > toolbar (e.g. konsole).
> > The "Show..." item was always stuck at its initial state as the
> > KToggleAction::plug() was not called for the menu as can be seen below.
> > Thanks a lot to David Faure for giving me a hand initially.
> > OK to commit?
> > Cheers,
>
> There were some corruption of the patch due to line wraps. I have attached
> the patch as a file this time.
>
> Cheers,

Thank you for your patch. It looks quite good, but I solved the problem a 
littlebit different at the moment. Please try and tell me if it works for you 
though.

My problem with your patch has been, that in the single bar mode the action 
itself is never plugged into the menu, but only the "sub action". That makes 
is a littlebit difficult to replace the entry with the submenu, when a switch 
to the multi toolbar mode happens. 

My solution at the moment, which is open for discussions, is that I just 
forward the signals between the action and the child actions.

Kind regards
Joseph Wenninger





More information about the kde-core-devel mailing list