KFileDialog toolbar

[Aaron J. Seigo]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi...

something that has bugged me about KFileDialog for a while is the toolbar.

in specific there is the "gear menu" that has some view options, and then 
there are some view options on the toolbar. this means that the user has to 
learn two differenet UI pathways to change view settings. 

the toolbar icons are also only meaningful if you know what they do (e.g. 
experimentation. there are tooltips, but it could be better.

also in the view submenu of the gear menu there is a radio group consisting of 
"Single view" and "Seperate Directories" .. in reality this is just a 
toggling on and off of the seperate directories sidebar .. it would make 
sense in its current form if other view options could be defined at run time 
(thereby inflating the number of radio group options to be >2) .. however, it 
seems this is not possible currently?

there is also a keyboard shortcut for the shortcuts sidebar but not for the 
preview area, which is inconsistent as from the user's perspective these 
things are the same type of "thing", that is: an side add-on to the main 
view.

so i finally sat down tonight and did something about it. the rather 
unexciting but IMO more consistent results can be seen at:

	http://urbanlizard.com/~aseigo/kfiledlg.png

or tried out first hand by applying the attached patch to kdelibs/kio/kfile

the two things i'm uncertain about:

 o does anything outside of kdiroperator and kfiledialog use the "single" 
action? (i can search lxr if nobody knows)
 o are view add-ons supported through some mechanism right now?
 
note that the only change to any header was the removal of a private slot from 
kdiroperator.

comments?

- -- 
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

"Everything should be made as simple as possible, but not simpler" 
    - Albert Einstein
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9HSWC1rcusafx20MRAi39AKCeaF+jiXZX2WQ/mTNc8wSVc/9rDgCdFVEU
tS7Hb3ArA8KErahBT5mq+r0=
=u0x/
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kfiledialog_toolbar_reorder.diff
Type: text/x-diff
Size: 5936 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20020628/63177560/attachment.diff>