[PATCH] Bug in properties dialog
zander at planescape.com
Tue Jun 11 18:05:37 BST 2002
On Tue, Jun 11, 2002 at 10:48:07AM -0400, Nadeem Hasan wrote:
> Open propertires dialog for a file with root.root ownership and goto
> "Permissions" tab. Here you will see the "Group" label in bold, which
> gives the impression that those set of permissions are in effect. This
> is wrong, as actually "Others" is in effect for this file. I hope this
> makes it clear.
> > > Isn't this wrong, or did I miss anything?
> > I agree with Thomas's answer - please do not commit -,
> > but I still wonder what the bug is.
> I hope you have seen it by now :)
Yep, I see.
Please check the following patch. Its against the BRANCH, maybe somebody can
forward-patch the diff. (If ok)
Thanx for pointing this out, you were quite close the the fix :)
RCS file: /home/kde/kdelibs/kio/kfile/kpropertiesdialog.cpp,v
retrieving revision 184.108.40.206
diff -u -3 -p -b -r220.127.116.11 kpropertiesdialog.cpp
--- kpropertiesdialog.cpp 2002/05/02 17:26:22 18.104.22.168
+++ kpropertiesdialog.cpp 2002/06/11 17:08:39
@@ -1404,6 +1404,14 @@ KFilePermissionsPropsPlugin::KFilePermis
groupList += name;
+ // Set in bold the effective rights for the user.
+ if (isMyFile)
+ else if (groupList.contains(strGroup))
/* add the group the file currently belongs to ..
* .. if its not there already
@@ -1459,13 +1467,6 @@ KFilePermissionsPropsPlugin::KFilePermis
- if (isMyFile)
- else if (groupList.contains(strGroup))
// QString KFilePermissionsPropsPlugin::tabName () const
Thomas Zander zander at planescape.com
We are what we pretend to be
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 232 bytes
Desc: not available
More information about the kde-core-devel