[PATCH] Bug in properties dialog

[Thomas Zander]

You missed the fact that the current group should be there, otherwise you
are not showing the info that is really there, and you change the group
to another when pressing OK. (even when not changing anything)

Plus that pressing OK while not changing the group does not do a chgrp.


On Mon, Jun 10, 2002 at 08:13:58PM -0400, Nadeem Hasan wrote:
> Hi,
> 
> The permissions tab on properties dialog has code which always adds the
> file's group to the user's group list. This has a side effect that the
> "Group" line is always highlighted if the user is not the owner of the
> file. Isn't this wrong, or did I miss anything?
> 
> OK to commit?
> 
> Cheers,
> -- 
> Nadeem Hasan
> nhasan at nadmm.com
> http://www.nadmm.com/
> 
> 
> Index: kfile/kpropertiesdialog.cpp
> ===================================================================
> RCS file: /home/kde/kdelibs/kio/kfile/kpropertiesdialog.cpp,v
> retrieving revision 1.224
> diff -u -r1.224 kpropertiesdialog.cpp
> --- kfile/kpropertiesdialog.cpp 2002/05/28 21:08:58     1.224
> +++ kfile/kpropertiesdialog.cpp 2002/06/11 00:09:53
> @@ -1428,12 +1428,6 @@
>        groupList += name;
>    }
> 
> -  /* add the group the file currently belongs to ..
> -   * .. if its not there already
> -   */
> -  if (!groupList.contains(strGroup))
> -    groupList += strGroup;
> -
>    l = new QLabel( i18n("Group:"), gb );
>    gl->addWidget (l, 2, 0);
> 
> 

-- 
Thomas Zander                                           zander at planescape.com
                                                 We are what we pretend to be
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 232 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20020611/631aacaf/attachment.sig>