[PATCH] KMainWindow::applyMainWindowSettings & SaveMainWindowSettings

[Nadeem Hasan]

On Friday 07 June 2002 06:43 pm, Waldo Bastian wrote:
> On Friday 07 June 2002 02:42 pm, Nadeem Hasan wrote:
> > Hi,
> >
> > If the group name is not passed to the above two methods, the group that
> > used to read/write settings is completely random and results in the
> > settings not getting restored properly. The attached patch defaults the
> > group to "MainWindowSettings" to make the behaviour predictable.
>
> The behaviour is already predictable. If no group is specified it uses the
> current group. Changing that behaviour would break backwards compatibility.

That would mean the app developer has to make sure that the same group is set
before calling these methods. Not very nice IMO, as it may break the app very
easily once the code starts to get shuffled around.

> > BTW, why is the "group" parameter documented as "For internal use only"?
>
> I have no idea. I suggest to update the documentation to include that the
> settings are saved to "group" and that if "group" is empty the current
> group is used.

Yes, I think this *should* be done to make it clear.

Cheers,
-- 
Nadeem Hasan
nhasan at nadmm.com
http://www.nadmm.com/