[PATCH]: menu button in window deco

[Aaron J. Seigo]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi ...

while experimenting with kwin window decorations, i discovered that single 
clicking the menu button when the menu is already shown does not hide the 
menu. this is unlike other menus in KDE.

even worse, double clicking on the menu button actually closes the window! 
this is hidden, destructive, duplicated behaviour that is overloaded onto a 
widget whose purpose is not closing windows (it's popping up a menu).

the attached patch applies to the appropriate window decos in kdebase and 
changes the menu button to hide the popup when clicked if the menu is 
visible, and not to close the window when the button is double clicked.

talking with frederik on IRC i discovered that the "double click == close" is 
how it works (worked?) in Windows. therefore i have left it as is in quartz 
and redmond, since those are both windows-alikes (as i understand it?)

if the patch is approved for committing, i'd like to make similar changes to 
the decos in kdeartwork ...

take care.

- -- 
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

"Everything should be made as simple as possible, but not simpler"
    - Albert Einstein
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9OLrj1rcusafx20MRAnN9AKCF+QGclFETgXzSCCmIFUDA/sbnnwCglNGZ
lC332lEmBDpn5CmaPt0Ekz8=
=50mL
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: menuButton.diff
Type: text/x-diff
Size: 8056 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20020719/267c76e4/attachment.diff>