PATCH: kdelibs/kdecore/kstringhandler.cpp tagURLs() method

[Marc Mutz]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 12 July 2002 10:09, Stephan Hermann wrote:
<snip>
> No.
> 	"*" == matching 0 or more times
> 	+   == matching 1 or more times
>
> We want to check URLs not shortcuts like gg: or some malformed urls
> out of the kurl testsuite ;)
>
> so + is the right choice...but I got a mistake in here and fixed it
> (good point with testsuites, thx harri :)) a "/" was missing.
>
> > 2: a class with a single char?
>
> you mean \d ? you're right..this is one of the mistakes

No, I meant what I taged with "^2" in the line below the regexp: You 
wrote "[/]", which is just equivalent to "/". And for (1), you wrote 
"{0,}", which would normally be written "*" and for (3) you wrote 
"{0,1}", which is:

> > 3: wouldn't this be "?"
>
> sure

exactly. And it's still in your regexp. ;-)

> > 4: see (1)
>
> nope

but yes ;-)

Marc

- -- 
Marc Mutz <mutz at kde.org>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9MBYR3oWD+L2/6DgRAmRoAKCHbE+3KSyLlKc2ooWA5lznjDF9iACePo2k
0i3ma4H5iWvgbUGkZgEVzR0=
=KwdL
-----END PGP SIGNATURE-----