KMimeMagic::finishResult() useless ?

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 04 July 2002 00:40, aleXXX wrote:
> Hi,
> 
> while looking at kmimemagic.cpp I found that this private function is never 
> called. Can it be removed ?
It's already #if 0'ed (feel free to do the same to the line in the .h, forgot do to that)

> Or is it there for future extensions, where the mimetype-string may contain 
> an encoding entry ?
Well, it's there because it comes from the apache mimemagic code, which
does support encoding in the mimetype string. It's commented out in
KMimeMagic since we don't support that at the moment, but if anyone wants
to introduce that somehow, the code for it is already there.
Not that it's make much sense IMHO though (we all know how badly
heuristics to find out the encoding of a file work).

> But why is it then commented out in KMimeMagic::findBufferType() and 
> findFileType() and replaced with a simple stripWhiteSpace() ?
See above.

> Would a mimetype string with encoding look like "text/html gzip" ?
Hmm, that's not an encoding, that's a compression method.
Encoding is usually stuff like utf8, iso-8859-15, etc.

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KOffice-1.2-beta2 is out! http://dot.kde.org/1025176121/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9JC6272KcVAmwbhARAvKuAJ9PmjXEpB7CjsTXp7KFp7irXA0MUwCfbU0u
RLultoHx2LMoYsJrRGTvB6M=
=5qJE
-----END PGP SIGNATURE-----