[RFC][PATCH] kwin/workspace: don't force new placement after moving to different desktop

Melchior FRANZ a8603365 at unet.univie.ac.at
Fri Aug 30 10:21:35 BST 2002


What bugs me since a while is, that kwin destroys my deliberate window
placement, when I move a window to another desktop. There's a comment in
workplace:

| the old position is most probably inappropriate on the new desktop
| thus we place the client again, before we show it, [...]

but IMHO that's wrong. Why should the window placement that was OK for
the current desktop suddenly be inappropriate on another desktop? Either
it was still KDE's original placement, anyway, or it got meanwhile changed
by the user. Either way, I can't imagine a case where it would be
desirable to change the placement while moving to another desktop.
That's ignoring the user's will and contradicts the "least surprise
paradigm". It reminds too much of Windows or other systems that try
to be wiser than the user.  :-> 

Hence I suggest to apply the following patch:

m.



RCS file: /cvs/kdebase/kwin/workspace.cpp,v
retrieving revision 1.357
diff -u -3 -p -r1.357 workspace.cpp
--- workspace.cpp       2002/08/28 15:17:29     1.357
+++ workspace.cpp       2002/08/30 09:21:19
@@ -2996,10 +2996,6 @@ void Workspace::sendClientToDesktop( Cli
     c->setDesktop( desk );
     if( desk == NETWinInfo::OnAllDesktops )
         c->setSticky( true );
-    else
-        //CT 01Jul2002 - the old position is most probably inappropriate on the new desktop
-        //    thus we place the client again, before we show it, but only if it's not OnAllDesktops
-        place(c);

     if ( c->isOnDesktop( currentDesktop() ) ) {
         c->show();





More information about the kde-core-devel mailing list